Use return values instead of assertions #12

Sidelobe · 2023-12-10T16:14:32Z

Assertions are useful for quick n' dirty stuff, but using the return values gives runtime control when handling errors.
Since the function documentation already uses return values, I assume this is how things were originally intended.

Thanks to http://github.com/pslack for some of the code snippets used here.

Partial credit for Peter J Slack (pslack)

…r on error

Credit to https://github.com/pslack -- thank you!

# Conflicts: # test/TestCommon.hpp

Sidelobe added 14 commits December 10, 2023 16:40

replaced assertions with return values when reading files

ee04bec

Partial credit for Peter J Slack (pslack)

Argument checks for functions & Tests to verify return value behaviou…

03cd877

…r on error

close file when content isn't proper

73cfbfa

Credit to https://github.com/pslack -- thank you!

remove test file only if it exists

c96f4af

try normal fopen on windows

24618af

remove only at beginning of test

56fe760

explicitly close files in tests

020f4f5

Merge branch 'master' into feature/ReturnVal-instead-Assert

441f751

# Conflicts: # test/TestCommon.hpp

close_write only upon successful open_write

93f2d35

test on linux

efce70b

fclose(NULL) is undefined behaviour

a505e8e

close after reading

5f557cf

use perror to print error details

d29e5b8

readme: added some instructions to run tests

16e73bb

Sidelobe merged commit 7523506 into master Dec 11, 2023
10 checks passed

Sidelobe deleted the feature/ReturnVal-instead-Assert branch December 11, 2023 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use return values instead of assertions #12

Use return values instead of assertions #12

Sidelobe commented Dec 10, 2023 •

edited

Loading

Use return values instead of assertions #12

Use return values instead of assertions #12

Conversation

Sidelobe commented Dec 10, 2023 • edited Loading

Sidelobe commented Dec 10, 2023 •

edited

Loading